Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NodeUtility.ts to fix: TypeError: Cannot read properties of undefined (reading 'length') #1639

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jackytank
Copy link

image

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @jackytank! ⭐

I believe that the root cause for the problem is that the value sent in is not of type Node, and therefore the property [PropertySymbol.nodeArray] is not available on the object.

In that case, the correct fix is to throw an exception when the value is not of type 'Node'.

We also need unit tests for it.

I can perhaps look into it more later tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants