fix: Remove redundant querySelector type check #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btea
approved these changes
Dec 22, 2024
capricorn86
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Thank you for your contribution @chocolateboy! ⭐
We should cover the case if selector is a Symbol.
chocolateboy
force-pushed
the
query-selector-remove-redundant-check
branch
2 times, most recently
from
e90f20b to
26169f1
Compare
Remove type check which is covered by (and shadows) subsequent checks
chocolateboy
force-pushed
the
query-selector-remove-redundant-check
branch
from
26169f1 to
8628617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a type check which is covered by (and shadows) subsequent checks.