Architecture updater (auto-sync) - Updating PPC #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2023
47 tasks
|
Hi @terorie! As you see I am just in the process to refactor the PPC module. You added the |
|
Hey @Rot127 unfortunately I made minimal progress here. There was a TableGen version mismatch between DarkKirb's patch and the one that Capstone needed. So, I started learning and rewriting TableGen rules by hand a long time ago but not sure where I left that off. Will share the code if I can find it again. Happy to pick this back up if there's interest. |
This would be great!
While I am at it I would try to add it on my own. But can I come back to your offer if I get stuck? The priority is to focus on refactoring as many archs as possible to use |
XVilka
suggested changes
May 11, 2023
This was referenced May 11, 2023
|
@Rot127 no objections against asserts if they are disabled by default. Maybe could be something like |
|
@terorie The Details |
This was referenced May 20, 2023
5 tasks
|
Rebased and squashed this PR onto the latest commit of #1949 (683a595). |
|
@Rot127 some fuzzer job bugs found - check the CI: https://github.com/capstone-engine/capstone/actions/runs/5494173005/jobs/10012800208?pr=2013#step:5:82 |
|
Yes, I am going to fuzz it as well before starting with Rizin integration. |
This was referenced Jul 11, 2023
|
Please rebase on top of latest |
XVilka
reviewed
Jul 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
XVilka
approved these changes
Aug 10, 2023
wargio
approved these changes
Aug 11, 2023
|
@Rot127 I will start to review the code this weekend. |
Have you had a chance to look? |
|
Would be nice to get this finally merged. It will reduce the amount of work and will make reviewing Aarch64 and Alpha PRs much easier. |
|
Yeah I am reviewing the code, still need time. |
|
Any updates? |
kabeor
approved these changes
Sep 5, 2023
|
Every thing looks great! Merged. |
|
Don't worry about red CI - it's a GitHub/network issue. Could be restarted later today: |
peace-maker
reviewed
Sep 12, 2023
| CS_AC_INVALID = 0, ///< Uninitialized/invalid access type. | ||
| CS_AC_READ = 1 << 0, ///< Operand read from memory or register. | ||
| CS_AC_WRITE = 1 << 1, ///< Operand write to memory or register. | ||
| CS_AC_READ_WRTE = |
This was referenced Mar 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on: #1949
Draft PR for the
auto-syncrefactor of PPC.It will also refactor quite a lot of general mapping logic used by
auto-syncarchsTODO
not setflag.add_cs_detailto newcs_mapping.hTHoperands fordcbttdfiles"0x04,0x00,0x00,0x00,0xf4,0xa4,0x00,0x08"->pstd 5, 8(4), 0Optimizations to do afterwards (in another PR)
;for proper formatting.CAPSTONE_DIETget_cs_reg_alias()for non LLVM register names.add_cs_group()for non LLVM instruction groups.PPCPredicate.hto LLVMCloses
closes #1909
closes #476
closes #1936
closes #1914
closes #1912
closes #1693
closes #1527
closes #944
Test again
bnemisses target address #1914 (missing reg alias)mtocrf,mfocrfmissesfxmimmediate #1903 (hits assert)Breaking changes
PPC_BC_NU_PLUS->PPC_PRED_NU_PLUS).cs_ppc.bc.reg = r0. This is fixed now.ppc_ops_crxis removed (wasn't used).