-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpha architecture #2071
Add Alpha architecture #2071
Conversation
Looks good so far. Nice work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add yourself in CREDITS.TXT
Generally looks good so far. Please don't forget to set the details of each operand (read/write access and the like). |
99436a1
to
fda1de3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
8190261
to
7f5e88c
Compare
7f5e88c
to
da9e71c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
da9e71c
to
36cf093
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6db22ad
to
acded82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! It looks very good!
Besides the few comments from above, please do the following before it can be merged:
Fuzz it a little more:
Apply the patch from here and test every byte combination for segfaults by running:
./cstool -d tc162 0 0xffffffff # With details enabled
./cstool -d tc162 0 0xffffffff # Without details
This way our chances for nasty surprises is lower.
Update the new updater
I replaced the Update-Arch.sh
script with a proper Python scripts.
You need to add Alpha there and can drop the Update-Arch.sh
change.
In suite/auto-sync/Updater/
you need to:
- Add
Alpha
toparse_args()
inASUpdater.py
,CppTranslator.py
andDiffer.py
- Add a configuration for Alpha in
suite/auto-sync/CppTranslator/arch_config.json
. The config file is documented inCppTranslator/README.md
. - Run the complete update procedure. It will fail at some point and you need to add some things to the Python scripts (e.g. to
CppTranslator/Patches/Includes.py
). Don't worry though, there shouldn't be many.
Also, I think the docs are still a confusingly written. And I update them in #2217.
Please, if you have any suggestions or run against walls, let me know. So this stuff can be made easier.
@XVilka @kabeor This last point (updating the updater) could be also moved into a separated PR. Just in case it should be merged earlier.
@kabeor could you please allow workflows to run again? Also, mark it as "ready for review"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as is. @R33v0LT Have you run the fuzzing?
In progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kabeor Please take a look when you find time.
It is really awesome, merged, thank you! |
This PR adds Alpha (auto-sync) architecture for capstone
New Features