Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manylinux docker images #2092

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Jul 19, 2023

closes #2091

@aquynh
Copy link
Collaborator

aquynh commented Jul 19, 2023 via email

manylinux1 is EOL since 2 years. Just like Python 3.6
Fixes wheel build.
@Rot127 Rot127 changed the title Remove python2.7 from build_wheel.sh Update manylinux docker images Jul 19, 2023
@Rot127
Copy link
Collaborator Author

Rot127 commented Jul 19, 2023

Python3.6 was the problem of #2091
Also it is EOL since 1,5 years. As well as the docker images (manylinux1).

The CI will just break more and more if we do not remove deprecated stuff. But if people want to use Python2 they can still do.

@Rot127
Copy link
Collaborator Author

Rot127 commented Jul 19, 2023

But besides that was Python2 never used in this workflow anyway. The binary was copied, but in the build_wheel.sh script everything was exclusively Python3 again.

@kabeor
Copy link
Member

kabeor commented Jul 20, 2023

Merge this first, but can you point where cause Python3.6 no longer support? As far as I know, CI test works well on 3.6. @Rot127

@kabeor kabeor merged commit 57de96f into capstone-engine:next Jul 20, 2023
@Rot127 Rot127 deleted the fix-build branch July 20, 2023 10:33
@Rot127
Copy link
Collaborator Author

Rot127 commented Jul 20, 2023

@kabeor Python3.6 seemed to work well until recently (#2091) (it only failed with those old versions, but it works now with more modern Python3.11). I could not pin point, what specifically the problem was. Maybe just the out-dated dockercross image (manylinux1, not maintained since 2 years).

But the newer dockercross images drop support (see table) for EOL CPython.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants