-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manylinux docker images #2092
Conversation
No, we want to keep supporting python2.
…On Wed, Jul 19, 2023, 17:44 Rot127 ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#2092
Commit Summary
- 17dec66
<17dec66>
Remove python2.7 from build_wheel.sh
File Changes
(1 file <https://github.com/capstone-engine/capstone/pull/2092/files>)
- *M* bindings/python/build_wheel.sh
<https://github.com/capstone-engine/capstone/pull/2092/files#diff-35447b24e822e4fd2c67a96ebff9c4e1082f8303c8765bea11bf34b0d89ea8a0>
(9)
Patch Links:
- https://github.com/capstone-engine/capstone/pull/2092.patch
- https://github.com/capstone-engine/capstone/pull/2092.diff
—
Reply to this email directly, view it on GitHub
<#2092>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNQNYFFGVXJE4H4JFLDPKDXQ63AZANCNFSM6AAAAAA2PXDXKU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
manylinux1 is EOL since 2 years. Just like Python 3.6 Fixes wheel build.
The CI will just break more and more if we do not remove deprecated stuff. But if people want to use Python2 they can still do. |
But besides that was Python2 never used in this workflow anyway. The binary was copied, but in the |
Merge this first, but can you point where cause |
@kabeor Python3.6 seemed to work well until recently (#2091) (it only failed with those old versions, but it works now with more modern Python3.11). I could not pin point, what specifically the problem was. Maybe just the out-dated dockercross image ( But the newer dockercross images drop support (see table) for EOL CPython. |
closes #2091