Use union in AArch64_AM_isSVEMaskOfIdenticalElements type punning fix
#2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rot127 what do you think? |
XVilka
approved these changes
Jan 11, 2024
|
@kabeor could you please merge this one too? |
|
Thanks！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor edit improves on #2237 by using
unioninstead ofmemcpythus dropping the dependence onmemcpyandstring.h. It also appears faster. It has been tested by the Rizin CI in rizinorg/rizin#4086.Apparently it's possible for the translator to use this form instead of the form in #2237.