Fix regressions in custom memory allocator support #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where new code started using malloc()/calloc()/free() directly instead of going through cs_mem_*().
github-actions
bot
added
ARM
Rot127
requested changes
Jan 19, 2024
| MCInst_insert0(MI, VCCPos + 3, Op); | ||
| free(Op); | ||
| MCOperand Op = *MCInst_getOperand(MI, TiedOp); | ||
| MCInst_insert0(MI, VCCPos + 3, &Op); |
There was a problem hiding this comment.
Not sure about this change. The free() was definitely wrong. But MCInst_insert0() doesn't move Op, but only saves the pointer. So it should be copied on the heap.
Could you take a look at it again.
There was a problem hiding this comment.
It makes a copy in the assignment it does here while dereferencing the pointer:
Line 56 in 25a69b5
There was a problem hiding this comment.
Ah of cause. Missed the line.
Rot127
approved these changes
Jan 20, 2024
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where new code started using malloc()/calloc()/free() directly instead of going through cs_mem_*().