Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Improve Apple detection #2263

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

sevan
Copy link
Contributor

@sevan sevan commented Feb 3, 2024

__APPLE__ is always defined & set to 1 on Darwin.
__apple_build_version__ not available on older releases.
This change allows Capstone to build on OS X 10.4.

__APPLE__ is always defined & set to 1 on Darwin.
@Rot127
Copy link
Collaborator

Rot127 commented Feb 3, 2024

Note though that the Makefile build method is effectively deprecated and will be dropped in the future.

@sevan
Copy link
Contributor Author

sevan commented Feb 3, 2024

Understood. It would be a shame since cmake has such a high cost.
I can build capstone 5.0.1 with GCC 4.0 on OS X 10.4, but cmake needs a C++11 compiler from cmake 3.10 onwards & may need an even more recent C++ compiler on current releases, so effectively that will become capstone's minimum requirement.

@Rot127
Copy link
Collaborator

Rot127 commented Feb 3, 2024

Just opened an issue where you can describe your use case. So we have tracked it somewhere (#2264).
@kabeor, please trigger the CI.

@sevan
Copy link
Contributor Author

sevan commented Feb 3, 2024

Thanks, I'll follow up there later on tonight when I have some time. Just popped in to ask if something is wrong on the CI side?

@sevan
Copy link
Contributor Author

sevan commented Feb 6, 2024

@Rot127 Is there something wrong with the CI here or have I missed where it's going wrong?

@Rot127
Copy link
Collaborator

Rot127 commented Feb 6, 2024

Yeah, something is broken currently.

@sevan
Copy link
Contributor Author

sevan commented Feb 6, 2024

No worries. Thanks for the sanity check. :)

@kabeor
Copy link
Member

kabeor commented Feb 15, 2024

6a55ef3 should fix the CI, please push a commit to trigger it.

@sevan
Copy link
Contributor Author

sevan commented Feb 15, 2024

Done.

@kabeor
Copy link
Member

kabeor commented Feb 23, 2024

Cool, thanks!

@kabeor kabeor merged commit 1c238b6 into capstone-engine:next Feb 23, 2024
12 checks passed
@sevan sevan deleted the patch-1 branch February 23, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants