-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: Improve Apple detection #2263
Conversation
__APPLE__ is always defined & set to 1 on Darwin.
Note though that the Makefile build method is effectively deprecated and will be dropped in the future. |
Understood. It would be a shame since cmake has such a high cost. |
Thanks, I'll follow up there later on tonight when I have some time. Just popped in to ask if something is wrong on the CI side? |
@Rot127 Is there something wrong with the CI here or have I missed where it's going wrong? |
Yeah, something is broken currently. |
No worries. Thanks for the sanity check. :) |
6a55ef3 should fix the CI, please push a commit to trigger it. |
Done. |
Cool, thanks! |
__APPLE__
is always defined & set to 1 on Darwin.__apple_build_version__
not available on older releases.This change allows Capstone to build on OS X 10.4.