Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python2 leftovers v2 #2395

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Python2 leftovers v2 #2395

merged 5 commits into from
Jul 1, 2024

Conversation

twizmwazin
Copy link
Contributor

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Rebases #2378 onto next, adds a commit updating shebangs to python3, I only found one.

...

Test plan

...

Closing issues

...

Rot127
Rot127 approved these changes Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete test_corpus.py. Shouldn't be used anywhere now.

@twizmwazin
Copy link
Contributor Author

I also noticed that there are some files in suite that are unported. Do we need to port those?

@XVilka
Copy link
Contributor

XVilka commented Jun 29, 2024

Most of the suite files probably should be removed as they are deprecated in favor of auto-sync tools.

Rot127
Rot127 approved these changes Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabeor @aquynh Please take a look.

@Rot127
Copy link
Collaborator

Rot127 commented Jun 29, 2024 •
edited
Loading

Most of the suite files probably should be removed as they are deprecated in favor of #2015 tools.

Yes, but let's do this before v6 (not here). Because they are not used. But this code here is run in the CI. Cleaning up suite is more than just the Pythin 2 files.

@Rot127
Copy link
Collaborator

Rot127 commented Jun 29, 2024 •
edited
Loading

@twizmwazin Any chance you find time to finish #2369 on behalf of @pyrox0? It is the only one for v5.0.2

kabeor
kabeor approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merged!

@kabeor kabeor merged commit 8ce088b into capstone-engine:next Jul 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 approved these changes

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twizmwazin @XVilka @Rot127 @kabeor