Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated packaging and cython #2400

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Remove deprecated packaging and cython #2400

merged 5 commits into from
Jul 24, 2024

Conversation

twizmwazin
Copy link
Contributor

@twizmwazin twizmwazin commented Jul 16, 2024 •
edited by Rot127
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Cherry-picks #2396 onto v5

Test plan

...

Closing issues

closes #2005
closes #2341
closes #2223

@twizmwazin
Copy link
Contributor Author

So this branch still uses the old wheel building method. I'm gonna copy over the changes for cibuildwheel from next.

Rot127
Rot127 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove the unnecessary files. Then this is good to go in my opinion.

bindings/python/tests/test_aarch64.py Outdated Show resolved Hide resolved
bindings/python/tests/test_alpha.py Outdated Show resolved Hide resolved
bindings/python/tests/test_iter.py Outdated Show resolved Hide resolved
@Rot127 Rot127 added this to the v5.0.2 milestone Jul 17, 2024
Rot127
Rot127 approved these changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabeor

@XVilka
Copy link
Contributor

XVilka commented Jul 20, 2024

Please add:
closes #2005
closes #2341
closes #2223

@Rot127 Rot127 mentioned this pull request Jul 22, 2024
Closed
kabeor
kabeor approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@kabeor kabeor merged commit 1bd2a32 into capstone-engine:v5 Jul 24, 2024
10 checks passed
@Rot127
Copy link
Collaborator

Rot127 commented Jul 24, 2024 •
edited
Loading

@twizmwazin
Unfortunately this broke the CI:

The v5 branch is red
There seems to be a left over CI job?

https://github.com/capstone-engine/capstone/actions/runs/10071537984/job/27841854148
https://github.com/capstone-engine/capstone/actions/runs/10071537984/job/27841854447

Do you think you will find time to look at it?
Otherwise I try to fix it. But will take longer.

This was referenced Sep 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 approved these changes

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@twizmwazin @XVilka @Rot127 @kabeor