-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back support for relocatable packages #2431
Conversation
3794b56
to
de35bb5
Compare
Could you please open a PR with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good to me. Can you tell me how quickly this becomes "tested" via NixOS?
@kabeor Why is the CI not running here? |
No idea, I do not use NixOS. They are doing something different that is specifically recommended against by CMake's documentation. This patch goes back to the behavior before #2134, unless those paths are absolute (as will be the case with NixOS). It's silly this workaround is required, but such is life 🤷🏻♂️ |
Really wired, may be affected by github downtime? Can we commit something or open a new pr to see if CI come back? |
This one also doesn't run CI: #2447 |
If CI doesn't run, it might be the sign of some error in the Actions YAML file. Check "Actions" log of the repository. |
de35bb5
to
7f87c20
Compare
Done! |
For me all of the checks are green now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
Your checklist for this pull request
Detailed description
The previous PR #2134 not only 'allowed' an absolute
CMAKE_INSTALL_LIBDIR
/CMAKE_INSTALL_INCLUDEDIR
, it also broke support for relocatable packages if the path was not absolute.These changes should also be cherry-picked in
v5
.Discussion: NixOS/nixpkgs#144170