-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cstest: use DOWNLOAD_EXTRACT_TIMESTAMP conditionally #2581
Merged
kabeor
merged 3 commits into
capstone-engine:next
from
hainest:thaines/cmake_cstest_download_extract_timestamp
Dec 16, 2024
Merged
cstest: use DOWNLOAD_EXTRACT_TIMESTAMP conditionally #2581
kabeor
merged 3 commits into
capstone-engine:next
from
hainest:thaines/cmake_cstest_download_extract_timestamp
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. That's the exact error this fixes. I'm not able to reproduce it. docker run --rm -it ubuntu:22.04
apt install -y cmake git g++ libyaml-dev
cmake --version
cmake version 3.22.1
git clone --depth=1 https://github.com/capstone-engine/capstone.git
cd capstone
git fetch origin pull/2581/head:PR2581
git checkout PR2581
mkdir build
cd build
cmake .. -DCAPSTONE_BUILD_SHARED_LIBS=ON -DCAPSTONE_BUILD_CSTEST=ON |
Rot127
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Really appreciate it.
This feature was added in CMake 3.24.0, so this allows older CMakes to still build the tests.
hainest
force-pushed
the
thaines/cmake_cstest_download_extract_timestamp
branch
from
December 16, 2024 17:24
b63a4b0
to
809f493
Compare
Rot127
approved these changes
Dec 16, 2024
kabeor
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
N/A
Detailed description
This feature was added in CMake 3.24.0, so this allows older CMakes to still build the tests.
Test plan
N/A
Closing issues
N/A