Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release with PHP 8.0 #269

Closed
wants to merge 1 commit into from

Conversation

pierredup
Copy link

Creating the release with PHP 8.2 means the phar will only work with PHP >= 8.2, because the composer platform_check.php script includes a check for PHP >= 8.2, running the phar on anything lower triggers the following fatal error:

Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.2.0". You are running 8.1.31. in phar:///Users/pierre/projects/...../vendor/bin/captainhook/vendor/composer/platform_check.php on line 24

@sebastianfeldmann
Copy link
Collaborator

sebastianfeldmann commented Feb 11, 2025

It should not because the release should run with a composer platform configuration of 8.0

It uses composer.phar.json

Running it on 8.0 will fail because Box the tool to build the PHAR requires 8.2

@sebastianfeldmann
Copy link
Collaborator

sebastianfeldmann commented Feb 11, 2025

Damn it I see the problem there is a yaml condition on the 8.0 platform json ... I'll remove it and create a new release

@sebastianfeldmann
Copy link
Collaborator

Thanks for reporting the issue :)

@pierredup pierredup deleted the patch-1 branch February 11, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants