Refactor deployed model labels #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradithya
requested changes
Feb 2, 2023
|
Can you review #348 and rebase this PR against that. I think the e2e flakiness is due to kserve |
Co-authored-by: yadavsunny05 <yadav.sunny05@gmail.com>
Co-authored-by: yadavsunny05 <yadav.sunny05@gmail.com>
Co-authored-by: yadavsunny05 <yadav.sunny05@gmail.com>
ariefrahmansyah
force-pushed
the
refactor-deployment-labels
branch
from
8f40c83
to
9181b97
Compare
ariefrahmansyah
commented
Feb 6, 2023
pradithya
approved these changes
Feb 6, 2023
tiopramayudi
reviewed
Feb 6, 2023
|
|
||
| // InitKubernetesLabeller builds a new KubernetesLabeller Singleton | ||
| func InitKubernetesLabeller(p string) { | ||
| prefix = p |
There was a problem hiding this comment.
can we do validation whether the prefix is valid or not? e.g "goto/gojek/" is not a valid prefix, if this value passed during init of merlin api, user won't be able to do anything
There was a problem hiding this comment.
Great suggestion. We added the validation for prefix.
api/models/metadata.go
Outdated
| labelEnvironment = "gojek.com/environment" | ||
| labelUsersPrefix = "gojek.com/%s" | ||
| LabelAppName = "app" | ||
| LabelComponent = "component" |
There was a problem hiding this comment.
do we need to expose this const?
There was a problem hiding this comment.
Currently, only LabelOrchestratorName that used by other packages, so yeah, we will change other to local variables.
Co-authored-by: yadavsunny05 <yadav.sunny05@gmail.com>
2 tasks
tiopramayudi
approved these changes
Feb 6, 2023
|
lgtm |
5 tasks
ariefrahmansyah
added a commit
that referenced
this pull request
Apr 17, 2023
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> **What this PR does / why we need it**: <!-- Explain here the context and why you're making the change. What is the problem you're trying to solve. ---> 1. The image-building jobs in Merlin are timing out. After some investigation, we found that one of the root causes is the node pool got scaled down resulting in the image building pods to be rescheduled. This PR adds "cluster-autoscaler.kubernetes.io/safe-to-evict": "false" to avoid the pod get killed and rescheduled. 2. In Refactor deployed model labels #346, we managed to propagate user labels to models and batch prediction jobs, but not to image builder jobs (here). This PR includes adding project + model version labels to image builder job. 3. This PR also improve e2e test by: a. Removing the duplicate of kserve-controller-manager statefulset as in kserve 0.9.0 manifest has both of statefulset and deployment b. Removing kserve-controller-manager's cpu limits **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note NONE ``` **Checklist** - [x] Added unit test, integration, and/or e2e tests - [x] Tested locally - [x] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduce API changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The labels implementation of Merlin resources (model services, batch jobs) is having two major limitations:
These drawbacks limit the user to have more flexibility on using label for their tracking.
This PR make following changes:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Checklist