Support resource configuration for imagebuilder #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terryyylim LGTM, can you update the helm chart as well? |
pradithya
approved these changes
Feb 20, 2023
pradithya
reviewed
Feb 21, 2023
charts/merlin/values-e2e.yaml
Outdated
| @@ -74,6 +74,13 @@ merlin: | |||
| dockerfilePath: "docker/app.Dockerfile" | |||
| buildContextURI: "git://github.com/gojek/merlin.git#refs/tags/v0.19.0" | |||
| mainAppPath: /merlin-spark-app/main.py | |||
| resourceRequestsLimits: | |||
There was a problem hiding this comment.
nit: I think resources is more concise.
pradithya
approved these changes
Feb 21, 2023
terryyylim
force-pushed
the
support-imagebuilder-resource-configuration
branch
from
11114f7
to
c2c34d8
Compare
|
Can you also update Merlin helm chart in caraml-dev/helm-charts: https://github.com/caraml-dev/helm-charts/tree/main/charts/merlin ? |
👌🏻 Yup! I'll update it once this chart has been tested with |
shydefoo
added a commit
that referenced
this pull request
Feb 22, 2023
* upstream/main: Support resource configuration for imagebuilder (#351)
This was referenced Feb 22, 2023
Merged
terryyylim
added a commit
that referenced
this pull request
Feb 24, 2023
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> **What this PR does / why we need it**: <!-- Explain here the context and why you're making the change. What is the problem you're trying to solve. ---> Resource configuration for imagebuilder was introduced in #351, but it was missing `Decode` method that is required by envconfig, as described in the documentation - https://github.com/kelseyhightower/envconfig#custom-decoders. **Which issue(s) this PR fixes**: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes # **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note NONE ``` --------- Co-authored-by: Tio Pramayudi <itok54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, Merlin image building jobs don't support resource configuration, and requests.cpu is hardcoded. Without requests.memory configured on them, it's common to see jobs failing with OOMKilled error if multiple jobs are running concurrently. This PR supports resource configuration so that some reasonable amount of memory can be set to mitigate this issue. In addition, the GKE autoscaler can spin up another node if multiple jobs are running concurrently, instead of placing all of the jobs onto the same node, and causing them to fight for available memory.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Checklist