-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify service account for kaniko jobs #352
Merged
Merged
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c7adb69
Add capability to specify kaniko service account
shydefoo d2fdfc6
Add kaniko service account to chart
shydefoo 8eea1f8
Modify batch predictor docker file
shydefoo ff92a6c
Add test for sa, fix linting
shydefoo 427fba3
Merge remote-tracking branch 'upstream/main' into enable-wi-kaniko
shydefoo 667c674
Add kaniko service account to helm chart
shydefoo be8e758
Increase memory to kserve
shydefoo 2fc9733
Add kaniko service account template
shydefoo 876c9df
Merge remote-tracking branch 'upstream/main' into enable-wi-kaniko
shydefoo 1fe39d7
Fix merlin chart
shydefoo 56ca8e2
Set kaniko sa name based on create boolean
shydefoo 9af217c
Fix test case issue
shydefoo a13dcc0
Upgrade pip in e2e script
shydefoo 59f1a32
Use python 3.10.6
shydefoo 0442b78
Increase kserve memory overlay
shydefoo 7f248d8
Reduce kserve memory requested
shydefoo c87b118
Remove changes to e2e test
shydefoo 7ce63ac
Specify python version in e2e test
shydefoo d103439
Set pytest number of workers to 4
shydefoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{{- if and .Values.merlin.imageBuilder.serviceAccount .Values.merlin.imageBuilder.serviceAccount.create }} | ||
apiVersion: v1 | ||
kind: ServiceAccount | ||
metadata: | ||
name: {{ .Values.merlin.imageBuilder.serviceAccount.name }}-{{ .Release.Name }} | ||
namespace: {{ .Release.Namespace }} | ||
{{- if .Values.merlin.imageBuilder.serviceAccount.annotations }} | ||
annotations: | ||
{{- toYaml .Values.merlin.imageBuilder.serviceAccount.annotations | nindent 4 }} | ||
{{- end }} | ||
labels: | ||
app: {{ include "merlin.name" . }} | ||
release: {{ .Release.Name }} | ||
helm.sh/chart: {{ include "merlin.chart" . }} | ||
app.kubernetes.io/name: {{ include "merlin.name" . }} | ||
app.kubernetes.io/instance: {{ .Release.Name }} | ||
app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
{{- if .Values.merlin.imageBuilder.serviceAccount.labels }} | ||
{{- toYaml .Values.merlin.imageBuilder.serviceAccount.labels | nindent 4 }} | ||
{{- end }} | ||
{{ end }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is there any reason not to use full name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hang on, i think this is wrong, will change to just use
without the
{{ .Release.Name }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But without the release name, there could be conflict of service account when there is multiple merlin release in same namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that was my initial thought, but then when specifying service account specified externally it should respect the name provided. Pushing a fix for this.