Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to caraml-dev/helm-charts #391

Merged
merged 10 commits into from
May 15, 2023
Merged

Migrate to caraml-dev/helm-charts #391

merged 10 commits into from
May 15, 2023

Conversation

ariefrahmansyah
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah commented May 7, 2023 •
edited
Loading

What this PR does / why we need it:

Deprecate Helm charts in this repository as we already migrated them to https://github.com/caraml-dev/helm-charts

This PR also:

  1. Update k8s version that used by k3d to 1.25 to avoid random webhook failure Random webhook failures with EOF k3s-io/k3s#5835
  2. Update Istio and Knative version

Does this PR introduce a user-facing change?:

NONE

Checklist

  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduce API changes

@ariefrahmansyah ariefrahmansyah marked this pull request as ready for review May 9, 2023 03:49
krithika369
krithika369 reviewed May 11, 2023
View reviewed changes
krithika369
krithika369 approved these changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@krithika369 krithika369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. The rest LGTM. Thanks, @ariefrahmansyah !

@ariefrahmansyah ariefrahmansyah mentioned this pull request May 15, 2023
Open
@ariefrahmansyah ariefrahmansyah merged commit 40d56d8 into main May 15, 2023
@ariefrahmansyah ariefrahmansyah deleted the caraml-helm-charts branch May 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiopramayudi tiopramayudi tiopramayudi approved these changes

@krithika369 krithika369 krithika369 approved these changes

@terryyylim terryyylim Awaiting requested review from terryyylim

@pradithya pradithya Awaiting requested review from pradithya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariefrahmansyah @tiopramayudi @krithika369