fix: Add precautionary logic for PDB #436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PDB support was introduced in #420. In some scenarios, the PDB can create problems. As an example, if PDB is configured to have a minimum of 20% replicas available and there is only one replica in the deployment, it's not possible to drain that node. To prevent such issues, this PR introduces some precautionary checks, - ensuring that at least 1 replica of the deployment can be removed:
It's enough to check
ceil(r * p) < r
where r is the minReplicas because:Does this PR introduce a user-facing change?:
Checklist