-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): Update go dependencies in merlin api server #551
Conversation
54f42f7
to
5cbbc45
Compare
b92ba8c
to
664d148
Compare
b273234
to
6d69868
Compare
@deadlycoconuts can you help update/rebase your branch? You should be able to do it from UI by clicking the |
b8c42de
to
f15f022
Compare
Thanks for the reminder; I just rebased my branch! :D So many PRs being merged during this short time x_x |
f15f022
to
5b1694c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, Zi Yi! Especially for your comments, they are guiding me when reviewing this PR.
5b1694c
to
c004243
Compare
Thanks a lot for the review @ariefrahmansyah ! :D I'll be merging this now! |
Description
This MR basically bumps a couple of Go package dependencies used by the Merlin API server, which in turn is imported by the Turing API server and will have its own dependencies updated in a separate PR (the updates in the PR will allow the dependencies of the Turing API server to also be updated without having to be pinned to the versions used in the Merlin API server). The version of Go used has also been bumped up from 1.20 to 1.22.
Main packages updated:
Some minor refactoring was performed on structs that may have changed or on functions called due to the changes in their expected arguments - these are annotated directly on the diffs.
Modifications
api/cluster/controller.go
- Updated the KServe controller functions as they now require a contextapi/cluster/resource/templater.go
- Updated theHandler
field of aProbe
struct to aProbeHandler
fieldapi/go.mod
- Updated various packages hereTests
Checklist
Release Notes