Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): Update go dependencies in merlin api server #551

Merged
merged 15 commits into from
Apr 8, 2024

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Mar 12, 2024

Description

This MR basically bumps a couple of Go package dependencies used by the Merlin API server, which in turn is imported by the Turing API server and will have its own dependencies updated in a separate PR (the updates in the PR will allow the dependencies of the Turing API server to also be updated without having to be pinned to the versions used in the Merlin API server). The version of Go used has also been bumped up from 1.20 to 1.22.

Main packages updated:

- github.com/GoogleCloudPlatform/spark-on-k8s-operator
- github.com/google/go-containerregistry 
- github.com/kserve/kserve
- k8s.io/api 
- k8s.io/apimachinery
- k8s.io/client-go
- knative.dev/networking
- knative.dev/pkg
- knative.dev/serving
- sigs.k8s.io/controller-runtime

Some minor refactoring was performed on structs that may have changed or on functions called due to the changes in their expected arguments - these are annotated directly on the diffs.

Modifications

  • api/cluster/controller.go - Updated the KServe controller functions as they now require a context
  • api/cluster/resource/templater.go - Updated the Handler field of a Probe struct to a ProbeHandler field
  • api/go.mod - Updated various packages here

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

NONE

@deadlycoconuts deadlycoconuts self-assigned this Mar 12, 2024
@deadlycoconuts deadlycoconuts added the maintenance Dependency updates and other chores label Mar 12, 2024
@deadlycoconuts deadlycoconuts force-pushed the update_merlin_api_server_dependencies branch from 54f42f7 to 5cbbc45 Compare March 12, 2024 07:55
api/go.mod Outdated Show resolved Hide resolved
@deadlycoconuts deadlycoconuts force-pushed the update_merlin_api_server_dependencies branch from b92ba8c to 664d148 Compare March 13, 2024 02:22
@deadlycoconuts deadlycoconuts force-pushed the update_merlin_api_server_dependencies branch 2 times, most recently from b273234 to 6d69868 Compare March 26, 2024 06:16
@deadlycoconuts deadlycoconuts marked this pull request as ready for review March 27, 2024 06:19
@ariefrahmansyah
Copy link
Contributor

@deadlycoconuts can you help update/rebase your branch?

You should be able to do it from UI by clicking the Update branch button:
image

@deadlycoconuts deadlycoconuts force-pushed the update_merlin_api_server_dependencies branch 2 times, most recently from b8c42de to f15f022 Compare April 1, 2024 09:01
@deadlycoconuts
Copy link
Contributor Author

deadlycoconuts commented Apr 1, 2024

Thanks for the reminder; I just rebased my branch! :D So many PRs being merged during this short time x_x

@deadlycoconuts deadlycoconuts force-pushed the update_merlin_api_server_dependencies branch from f15f022 to 5b1694c Compare April 1, 2024 09:52
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Zi Yi! Especially for your comments, they are guiding me when reviewing this PR.

api/go.mod Show resolved Hide resolved
@deadlycoconuts deadlycoconuts force-pushed the update_merlin_api_server_dependencies branch from 5b1694c to c004243 Compare April 6, 2024 02:03
@deadlycoconuts
Copy link
Contributor Author

Thanks a lot for the review @ariefrahmansyah ! :D I'll be merging this now!

@deadlycoconuts deadlycoconuts merged commit 2beab49 into main Apr 8, 2024
34 checks passed
@deadlycoconuts deadlycoconuts deleted the update_merlin_api_server_dependencies branch April 8, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependency updates and other chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants