Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: labelling bug in UI when editing user roles #95

Merged
merged 2 commits into from
May 8, 2024
Merged

fix: labelling bug in UI when editing user roles #95

merged 2 commits into from
May 8, 2024

Conversation

shydefoo
Copy link
Contributor

@shydefoo shydefoo commented May 8, 2024

Summary

  • When user roles are updated, the labels in the project are not included in the request body sent to mlp api
  • This causes the updated project to not have any labels
  • The fix is to set the labels field if it exists
  • This only occurs for create/update user roles. For delete roles this bug does not occur.

@shydefoo shydefoo self-assigned this May 8, 2024
deadlycoconuts
deadlycoconuts approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging and fixing this! 🚀

@shydefoo shydefoo merged commit e5c00c4 into main May 8, 2024
7 of 8 checks passed
@shydefoo shydefoo deleted the fix-user-roles-bug branch May 8, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

@ariefrahmansyah ariefrahmansyah Awaiting requested review from ariefrahmansyah

Assignees

@shydefoo shydefoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shydefoo @deadlycoconuts