Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename repository references #8

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Rename repository references #8

merged 2 commits into from
Dec 15, 2022

Conversation

terryyylim
Copy link
Contributor

What this PR does / why we need it:

The repository has been renamed from observation-service to timber. This PR updates references to the old repository name.

Which issue(s) this PR fixes:

NONE

@terryyylim terryyylim self-assigned this Dec 15, 2022
@terryyylim terryyylim added the documentation Improvements or additions to documentation label Dec 15, 2022
@terryyylim terryyylim temporarily deployed to manual December 15, 2022 04:47 — with GitHub Actions Inactive
@pradithya
Copy link
Member

I think we need to update the chart name too

@terryyylim terryyylim temporarily deployed to manual December 15, 2022 06:17 — with GitHub Actions Inactive
@terryyylim
Copy link
Contributor Author

I think we need to update the chart name too

Oh I thought it should stay the same, since there should be dataset-service chart later on as well right?

@pradithya
Copy link
Member

I think we need to update the chart name too

Oh I thought it should stay the same, since there should be dataset-service chart later on as well right?

I see, make sense. How should we call dataset-service? Timberland? 😄

@pradithya
Copy link
Member

I think we need to update the chart name too

Oh I thought it should stay the same, since there should be dataset-service chart later on as well right?

I see, make sense. How should we call dataset-service? Timberland? 😄

Just to confirm, this repository (timber) contains several component: dataset service, observation service, and log writers. Each will have separate helm chart correct?

@terryyylim
Copy link
Contributor Author

Just to confirm, this repository (timber) contains several component: dataset service, observation service, and log writers. Each will have separate helm chart correct?

Yup that is correct!

pradithya
pradithya approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@pradithya pradithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! LGTM

@terryyylim terryyylim temporarily deployed to manual December 15, 2022 06:46 — with GitHub Actions Inactive
@terryyylim terryyylim merged commit 7931b13 into main Dec 15, 2022
@terryyylim terryyylim deleted the great-rename branch February 7, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krithika369 krithika369 krithika369 approved these changes

@pradithya pradithya pradithya approved these changes

Assignees

@terryyylim terryyylim

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terryyylim @pradithya @krithika369