Add logic check to check for presence of env var before activating se…

…rvice account (#358)
caraml-dev · Aug 16, 2023 · 78ca7b3 · 78ca7b3
1 parent 1b55562
commit 78ca7b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/engines/pyfunc-ensembler-job/app.Dockerfile b/engines/pyfunc-ensembler-job/app.Dockerfile
@@ -4,7 +4,8 @@ FROM ${BASE_IMAGE}
 
 ARG MODEL_URL
 ARG GOOGLE_APPLICATION_CREDENTIALS
-RUN gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS}
+# Run docker build using the credentials if provided
+RUN if [[-z "$GOOGLE_APPLICATION_CREDENTIALS"]]; then gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS}; fi
 RUN gsutil -m cp -r ${MODEL_URL} .
 ARG FOLDER_NAME
 RUN /bin/bash -c ". activate ${CONDA_ENVIRONMENT} && conda env update --name ${CONDA_ENVIRONMENT} --file /${HOME}/${FOLDER_NAME}/conda.yaml"
diff --git a/engines/pyfunc-ensembler-service/app.Dockerfile b/engines/pyfunc-ensembler-service/app.Dockerfile
@@ -6,7 +6,8 @@ ARG MODEL_URL
 ARG FOLDER_NAME
 ARG GOOGLE_APPLICATION_CREDENTIALS
 
-RUN gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS}
+# Run docker build using the credentials if provided
+RUN if [[-z "$GOOGLE_APPLICATION_CREDENTIALS"]]; then gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS}; fi
 RUN gsutil -m cp -r ${MODEL_URL} .
 
 # Install dependencies required by the user-defined ensembler