Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add precautionary logic for PDB #353

Merged
merged 4 commits into from
Jul 27, 2023
Merged

fix: Add precautionary logic for PDB #353

merged 4 commits into from
Jul 27, 2023

Conversation

krithika369
Copy link
Collaborator

PDB support for router components was introduced in #346. This PR fixes some bugs / corner cases:

  • For ensembler, PDB should only be created for Docker / Pyfunc types (as Standard ensembler is embedded in the router deployment)
  • Do not create PDB if the min replica is too low, which can prevent node drain. See related Merlin PR for more details: fix: Add precautionary logic for PDB merlin#436

@krithika369 krithika369 added the type: bug Something isn't working label Jul 27, 2023
deadlycoconuts
deadlycoconuts approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all these fixes! 🎉 Just have a tiny question but it looks good!

@krithika369
Copy link
Collaborator Author

Thanks for the review. Merging.

@krithika369 krithika369 merged commit 0302624 into caraml-dev:main Jul 27, 2023
12 checks passed
@krithika369 krithika369 deleted the fix_pdb_condition branch July 27, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

@ariefrahmansyah ariefrahmansyah Awaiting requested review from ariefrahmansyah

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krithika369 @deadlycoconuts