Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: suggest local branches for push #2249

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

Trojan295
Copy link
Contributor

This PR changes to completion of git push to suggest local branches instead of remote branches.

To me, the current approach to show remote branches is not useful, because it suggests to push remote branches to remotes. The command git-push syntax per documentation is:

<refspec>…​

Specify what destination ref to update with what source object. The format of a parameter is an optional plus +, followed by the source object , followed by a colon :, followed by the destination ref .

So IMO, after the repository argument, carapace should suggest local branches, as the refspec starts with the source object.

@rsteube rsteube merged commit 7c9fcae into carapace-sh:master Feb 18, 2024
3 checks passed
@Trojan295 Trojan295 deleted the fix/push-use-local-branches branch February 23, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants