New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: respect namespace flag, when completing ApiResourceResources #2252

Merged

rsteube merged 1 commit into carapace-sh:master from Trojan295:fix/kubectl/logs-namespaces

Feb 19, 2024

Contributor

Trojan295 commented Feb 19, 2024 •

edited

Loading

Currently, when trying to autocomplete serveral command, which require an API resource and resource, the namespace flag is not respected.

kubectl logs -n other-ns pods/

shows pods from the current namespace, not other-ns.

This PR adds namespace parameter to the kubectl.ActionApiResourceResources.


          kubectl: respect namespace flag, when completing ApiResourceResources

325f148

rsteube merged commit 7c273d5 into carapace-sh:master

3 checks passed

Member

rsteube commented Feb 19, 2024

thanks

Trojan295 deleted the fix/kubectl/logs-namespaces branch

February 19, 2024 16:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet