Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: re-add support for legacy commands #2257

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

rsteube
Copy link
Member

@rsteube rsteube commented Feb 21, 2024

fix #2255

@rsteube rsteube merged commit f038a18 into master Feb 21, 2024
6 checks passed
@rsteube rsteube deleted the docker-legacy-commands branch February 21, 2024 10:07
@rsteube
Copy link
Member Author

rsteube commented Feb 21, 2024

fyi @giggio

Let's give this another try. I primarily removed the support due to the previous approach giving me some issues.
This should be fine and maintainable.

@giggio
Copy link

giggio commented Feb 21, 2024

@rsteube that is awesome. Is there a way to install using Go? I tried go install github.com/rsteube/carapace-bin@master but it failed with

go: downloading github.com/rsteube/carapace-bin v0.30.2-0.20240221100749-f038a18f0524
go: github.com/rsteube/carapace-bin@master: module github.com/rsteube/carapace-bin@master found (v0.30.2-0.20240221100749-f038a18f0524), but does not contain package github.com/rsteube/carapace-bin

@giggio
Copy link

giggio commented Feb 21, 2024

Nevermind, I looked at the github workflow and built it by cloning and building. I added it to a local bin folder and it is working. I'll remove it when you release a new version. Thanks!

For reference:

git clone https://github.com/rsteube/carapace-bin.git
cd carapace-bin
go generate ./cmd/...
ls cmd/ | xargs -I'{}' sh -c "cd ./cmd/{} && go build -v ."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker rmi: not showing images in Nushell
2 participants