Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm, kubectl: add namespace and kube-context completions #2258

Conversation

Trojan295
Copy link
Contributor

This adds a dependency on kubectl binary being present, but I guess it is fine.

@Trojan295 Trojan295 changed the title helm: add namespace and kube-context complations WIP: helm: add namespace and kube-context complations Feb 21, 2024
@rsteube
Copy link
Member

rsteube commented Feb 21, 2024

This adds a dependency on kubectl binary being present, but I guess it is fine.

Yes, that's fine. I just shows an error message during completion if it is missing.

pkg/actions/tools/helm/release.go Outdated Show resolved Hide resolved
@Trojan295 Trojan295 changed the title WIP: helm: add namespace and kube-context complations WIP: helm, kubectl: add namespace and kube-context completions Feb 21, 2024
@Trojan295 Trojan295 changed the title WIP: helm, kubectl: add namespace and kube-context completions helm, kubectl: add namespace and kube-context completions Feb 21, 2024
@rsteube rsteube merged commit 62e1d9e into carapace-sh:master Feb 21, 2024
3 checks passed
@Trojan295 Trojan295 deleted the feat/helm/add-namespace-and-context-completions branch February 23, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants