Updated nix completer with the new flake APIs #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the help command: carapace.Gen(helpCmd).PositionalAnyCompletion(
carapace.ActionCommands(rootCmd),
)e.g. |
|
I've added the ActionCommands to |
rsteube
requested changes
Apr 17, 2024
|
I've made the requested changes, but wasn't exactly sure what kind of error messages would be good on failure |
|
Just |
- Created an ActionInstallables for installables from flakes or nixpkgs - Added `--stdin` flags to commands taking installables - Added several subcommands under `nix flake` - Removed old subcommands that have been renamed or removed from the nix program
|
I've updated the ActionMessage calls to use |
rsteube
approved these changes
Apr 17, 2024
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--stdinflags to commands taking installablesnix flakeDue to #2348 (comment) tab completion for flake outputs was not implemented. Also,
nix helpfollows the somewhat common pattern of putting subcommands as positional arguments such asnix help flake showto show help fornix flake show. I wasn't aware of a good programatic way to generate those completions.