Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg position aware codec selection #2533

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

jopejoe1
Copy link
Contributor

This makes the completer aware if it should list the decoders or encoders when selecting completing a codec, not sure if this was done in the cleanest way?

@rsteube rsteube merged commit 14541ad into carapace-sh:master Sep 21, 2024
3 checks passed
@jopejoe1 jopejoe1 deleted the ffmpeg branch September 21, 2024 22:57
@rsteube
Copy link
Member

rsteube commented Sep 21, 2024

Thanks.

The whole completer is a messy initial version anyway, so this approach is fine.
I went with two additional actions (not that it's any better).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants