Fix #9 and add time range support for extractions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommited fetch the last month sessions. Plot data from pandas to CSV file.
…nd use current time as parameter
GabrielSimonetto
approved these changes
Oct 27, 2019
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9 by creating CSV files using panda's dataframe.to_csv. The files will be created in runtime at paratex/output and ignored by git. For now it creates a separated file for each session, in future we should add support for creating a big CSV file with all the attendances extraced.
For time range, the function expects two Date objects, start and end. If start and end are ommited last month's data will be used. If just end is ommited the end time will be the current date. If start is bigger than end a exception is raised.