Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card] Title tooltip requires polish #3645

Closed
JordanWSmith15 opened this issue Nov 14, 2022 · 0 comments · Fixed by #3649
Closed

[Card] Title tooltip requires polish #3645

JordanWSmith15 opened this issue Nov 14, 2022 · 0 comments · Fixed by #3649
Assignees
@erzhan-temir-mamyrov
Labels
severity: 2 Affects major functionality, has a workaround type: bug 🐛

Comments

@JordanWSmith15
Copy link
Collaborator

JordanWSmith15 commented Nov 14, 2022 •
edited
Loading

https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-card-card--with-ellipsed-title-tooltip-external-tooltip

  1. On hovering the dotted text, the cursor changes to a text cursor. Instead, it should change to a finger pointer 👆 to indicate that there is a click
  2. When the tooltip is open, and the user scrolls the page, the tooltip should automatically close. This will prevent odd scrolling/z-index issues, as noticed here https://jsw.ibm.com/browse/GRAPHITE-55562

Screen Shot 2022-11-14 at 9 51 46 AM

3. In storybook, when the storybook frame is made short, there is a React error
Screen.Recording.2022-11-14.at.9.53.13.AM.mov
@JordanWSmith15 JordanWSmith15 added type: bug 🐛 severity: 2 Affects major functionality, has a workaround status: needs triage 🔍 labels Nov 14, 2022
erzhan-temir-mamyrov added a commit that referenced this issue Nov 21, 2022
@erzhan-temir-mamyrov
chore(card): add cursor pointer to title with tooltip
ec3f830 
#3645
erzhan-temir-mamyrov added a commit that referenced this issue Nov 21, 2022
@erzhan-temir-mamyrov
feat(card): hide title tooltips on window scroll
a42a59d 
#3645
erzhan-temir-mamyrov added a commit that referenced this issue Nov 21, 2022
@erzhan-temir-mamyrov
chore(card): change tooltip auto orientation prop to custom hook
4dc0c34 
#3645
Merged
9 tasks
@kodiakhq kodiakhq bot closed this as completed in #3649 Dec 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erzhan-temir-mamyrov erzhan-temir-mamyrov

Labels
severity: 2 Affects major functionality, has a workaround type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(card): tooltips enhacements carbon-design-system/carbon-addons-iot-react
2 participants
@JordanWSmith15 @erzhan-temir-mamyrov