chore(deps): bump acorn from 5.6.2 to 5.7.4 #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [acorn](https://github.com/acornjs/acorn) from 5.6.2 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.6.2...5.7.4) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
blechner,
bryancboyd,
cgirani,
davidicus,
filipecorrea,
jessieyan,
leetosc,
scottdickerson,
sstone2423,
stuckless,
tay1orjones and
tomklapiscak
as code owners
|
Deploy preview for carbon-addons-iot-react ready! Built with commit feaf3ae https://deploy-preview-1008--carbon-addons-iot-react.netlify.com |
|
Quite a few important dependencies rely on this and Output from yarn why v1.12.3
[1/4] 🤔 Why do we have the module "acorn"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "acorn@6.0.5"
info Has been hoisted to "acorn"
info Reasons this module exists
- Hoisted from "rollup#acorn"
- Hoisted from "jsdom#acorn-globals#acorn"
- Hoisted from "eslint#espree#acorn"
info Disk size without dependencies: "1.07MB"
info Disk size with unique dependencies: "1.07MB"
info Disk size with transitive dependencies: "1.07MB"
info Number of shared dependencies: 0
=> Found "webpack#acorn@5.7.3"
info This module exists because "webpack" depends on it.
info Disk size without dependencies: "588KB"
info Disk size with unique dependencies: "588KB"
info Disk size with transitive dependencies: "588KB"
info Number of shared dependencies: 0
=> Found "rollup-plugin-node-globals#acorn@5.7.3"
info This module exists because "rollup-plugin-node-globals" depends on it.
info Disk size without dependencies: "588KB"
info Disk size with unique dependencies: "588KB"
info Disk size with transitive dependencies: "588KB"
info Number of shared dependencies: 0
=> Found "jsdom#acorn@7.1.0"
info This module exists because "jsdom" depends on it.
info Disk size without dependencies: "1.08MB"
info Disk size with unique dependencies: "1.08MB"
info Disk size with transitive dependencies: "1.08MB"
info Number of shared dependencies: 0
=> Found "acorn-dynamic-import#acorn@5.6.2"
info This module exists because "webpack#acorn-dynamic-import" depends on it.
info Disk size without dependencies: "588KB"
info Disk size with unique dependencies: "588KB"
info Disk size with transitive dependencies: "588KB"
info Number of shared dependencies: 0
=> Found "@storybook/react#acorn@6.4.0"
info Reasons this module exists
- "@storybook#react#webpack" depends on it
- Hoisted from "@storybook#react#webpack#acorn"
info Disk size without dependencies: "1.08MB"
info Disk size with unique dependencies: "1.08MB"
info Disk size with transitive dependencies: "1.08MB"
info Number of shared dependencies: 0
=> Found "@storybook/core#acorn@6.4.0"
info Reasons this module exists
- "@storybook#addon-storyshots#@storybook#core#webpack" depends on it
- Hoisted from "@storybook#addon-storyshots#@storybook#core#webpack#acorn"
info Disk size without dependencies: "1.08MB"
info Disk size with unique dependencies: "1.08MB"
info Disk size with transitive dependencies: "1.08MB"
info Number of shared dependencies: 0
=> Found "storybook-chromatic#acorn@5.7.3"
info Reasons this module exists
- "@storybook#addon-actions#react-inspector#storybook-chromatic#jsdom" depends on it
- Hoisted from "@storybook#addon-actions#react-inspector#storybook-chromatic#jsdom#acorn"
info Disk size without dependencies: "588KB"
info Disk size with unique dependencies: "588KB"
info Disk size with transitive dependencies: "588KB"
info Number of shared dependencies: 0
=> Found "corejs-upgrade-webpack-plugin#acorn@6.4.0"
info Reasons this module exists
- "@storybook#addon-storyshots#@storybook#core#corejs-upgrade-webpack-plugin#webpack" depends on it
- Hoisted from "@storybook#addon-storyshots#@storybook#core#corejs-upgrade-webpack-plugin#webpack#acorn"
info Disk size without dependencies: "1.08MB"
info Disk size with unique dependencies: "1.08MB"
info Disk size with transitive dependencies: "1.08MB"
info Number of shared dependencies: 0
=> Found "jest-environment-jsdom#acorn@5.7.3"
info Reasons this module exists
- "jest#jest-cli#jest-config#jest-environment-jsdom#jsdom" depends on it
- Hoisted from "jest#jest-cli#jest-config#jest-environment-jsdom#jsdom#acorn"
info Disk size without dependencies: "588KB"
info Disk size with unique dependencies: "588KB"
info Disk size with transitive dependencies: "588KB"
info Number of shared dependencies: 0
=> Found "storybook-chromatic#acorn-globals#acorn@6.0.5"
info This module exists because "@storybook#addon-actions#react-inspector#storybook-chromatic#jsdom#acorn-globals" depends on it.
info Disk size without dependencies: "1.07MB"
info Disk size with unique dependencies: "1.07MB"
info Disk size with transitive dependencies: "1.07MB"
info Number of shared dependencies: 0
=> Found "jest-environment-jsdom#acorn-globals#acorn@6.0.5"
info This module exists because "jest#jest-cli#jest-config#jest-environment-jsdom#jsdom#acorn-globals" depends on it.
info Disk size without dependencies: "1.07MB"
info Disk size with unique dependencies: "1.07MB"
info Disk size with transitive dependencies: "1.07MB"
info Number of shared dependencies: 0
✨ Done in 1.29s. |
|
Here's the source of my confusion, the actual security vulnerability linked above states
So after some digging it appears the deps relying on v5.x can be upgraded to 5.7.4 which contains the fix Whereas deps relying on v6.x need v6.4.1 to get the fix |
tay1orjones
reviewed
Mar 17, 2020
tay1orjones
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
I think dependabot simply updated this before v6.4.1 was released and 6.4.0 was incorrectly whitelisted at that time. Either way I've manually updated this branch to resolve acorn v6 to 6.4.1.
I validated locally that the build succeeded and outputs as expected. Additionally fired up storybook and things work as expected.
davidicus
approved these changes
Mar 17, 2020
|
🎉 This PR is included in version 2.57.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps acorn from 5.6.2 to 5.7.4.
Commits
6370e90Mark version 5.7.4fbc15b1More rigorously check surrogate pairs in regexp validator910e62bMark version 5.7.33442a80Make generate-identifier-regex capable of rewriting src/identifier.js22b22f3Raise specific errors for unterminated template literals1461c7cFix a lint error0c12f63Fix tokenizing of regexps after .of832c308Fix 404 url95ca55cMark version 5.7.2bba80abRemove another fixed test from the 262 whitelistDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.