Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeseries): the iseditable state was allowing interaction and not showing sampledata #1591

Merged
merged 3 commits into from
Sep 13, 2020

Conversation

scottdickerson
Copy link
Contributor

Closes #1565

Summary

  • This fixes a regression handling isEditable prop in the TimeSeriesCard

Change List (commits, features, bugs, etc)

  • fix(barChart): hide tooltip and ruler when hovering when editable
  • fix(TimeSeriesCard): memoization of series color is no longer the correct format, we need to update them in formatColors (lines variable just reverts back to series)
  • fix(time-series-card): hide ruler when hovering when editable

Acceptance Test (how to verify the PR)

  • Verify the isEditable stories for BarChartCard and TimeSeriesCard show data correctly and don't seem interactive.

@netlify
Copy link

netlify bot commented Sep 9, 2020

Deploy preview for carbon-addons-iot-react ready!

Built with commit 5f42782

https://deploy-preview-1591--carbon-addons-iot-react.netlify.app

@sstone2423 sstone2423 merged commit 1e7514f into master Sep 13, 2020
@sstone2423 sstone2423 deleted the fix-timeseries-iseditable branch September 13, 2020 16:16
@tay1orjones
Copy link
Member

🎉 This PR is included in version 2.115.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TimeSeriesCard] isEditable state is broken
5 participants