-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding default date format pattern for table, timeseries, bar and combochart cards #3721
Conversation
… combochart cards
✅ Deploy Preview for carbon-addons-iot-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
… combochart cards
…arbon-design-system/carbon-addons-iot-react into feat-add-default-dateformatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@herleraja By adding a default where none existed before we are causing a breaking change to our down stream consumers. This looks good to go but we just need to add the default props to be the old value. This will probably allow us to remove the snapshot changes and the changes to the unit test. I would also like to see a unit test where we provide this prop and see that the value then changes.
Closes #3720
Related to https://github.ibm.com/wiotp/Maximo-Asset-Monitor/issues/5050
Summary
defaultDateFormatPattern
which has a default valueL HH:mm:ss
Change List (commits, features, bugs, etc)
Acceptance Test (how to verify the PR)
L HH:mm
Now: The default date format is
L HH:mm:ss
--> https://deploy-preview-3721--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-card-tablecard--with-multiple-actionsRegression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.