Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding default date format pattern for table, timeseries, bar and combochart cards #3721

Merged
merged 11 commits into from
Mar 10, 2023

Conversation

herleraja
Copy link
Collaborator

@herleraja herleraja commented Feb 17, 2023

Closes #3720
Related to https://github.ibm.com/wiotp/Maximo-Asset-Monitor/issues/5050

Summary

  • adding default date format pattern for table, timeseries, bar and combochart cards. we exposed a optionally property defaultDateFormatPattern which has a default value L HH:mm:ss

Change List (commits, features, bugs, etc)

  • feat: adding default date format pattern for table, timeseriesbar and combochart cards

Acceptance Test (how to verify the PR)

Regression Test (how to make sure this PR doesn't break old functionality)

  • All the cards should work without any issues.

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 943f361
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/640a1d7384aee30008eaf8f0
😎 Deploy Preview https://deploy-preview-3721--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@davidicus davidicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herleraja By adding a default where none existed before we are causing a breaking change to our down stream consumers. This looks good to go but we just need to add the default props to be the old value. This will probably allow us to remove the snapshot changes and the changes to the unit test. I would also like to see a unit test where we provide this prop and see that the value then changes.

@davidicus davidicus dismissed jessieyan’s stale review March 10, 2023 12:39

prop-types were added

@kodiakhq kodiakhq bot merged commit 4457a4e into next Mar 10, 2023
@kodiakhq kodiakhq bot deleted the feat-add-default-dateformatter branch March 10, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TableCard] Provide a default timestamp format across all the dashboard cards
4 participants