Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetimepickerv2): flyout menu change position to left-start when set --wrapper-width to 100% #3727

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

jessieyan
Copy link
Collaborator

@jessieyan jessieyan commented Feb 21, 2023

Closes #3620

Summary

  • If we default direction to BottomEnd and flyout (dropdown) menu is offscreen from top and right, we should still open dropdown from bottom-end direction.

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

In graphite,
image

In PAL,
image

Copied from Comments in PR

To Reproduce

Steps to reproduce the behavior:

  1. Go to single select story
  2. Set story-container --wrapper-width to 100%
    image
  3. Click on datetimepickerv2 input

Expect dropdown menu opens downwards with the direction name bottom-end in class iot--flyout-menu--body__bottom-end

Before: Dropdown opens in left-start direction

Screen.Recording.2023-02-21.at.2.48.44.PM.mov

Now: Dropdown opens in bottom-end direction (default)

Screen.Recording.2023-02-21.at.2.51.20.PM.mov

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@jessieyan jessieyan requested a review from davidicus as a code owner February 21, 2023 21:40
@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit a24452c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6408a97e7e32d200084c3e7a
😎 Deploy Preview https://deploy-preview-3727--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit bb394af into next Mar 9, 2023
@kodiakhq kodiakhq bot deleted the fix-3620 branch March 9, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DateTimePickerV2] Flyout menu change position to left start when set --wrapper-width to 100%
2 participants