Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(barchartcard): add maximum data points field #3753

Merged
merged 12 commits into from
Apr 18, 2023
Merged

feat(barchartcard): add maximum data points field #3753

merged 12 commits into from
Apr 18, 2023

Conversation

erzhan-temir-mamyrov
Copy link
Collaborator

@erzhan-temir-mamyrov erzhan-temir-mamyrov commented Mar 17, 2023

Closes #3663

Summary

  • Add number input field for maximum data points

Change List (commits, features, bugs, etc)

  • Add maximumDataPoints property to card editor
  • Add unit test
  • Update snapshots

Acceptance Test (how to verify the PR)

  • Go to this story
  • Open "Settings" tab
  • Change value of "Maximum data points" field
  • Verify applied changes in the "Action" tab

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 727c6d0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/643d9bf8e2d0af000862934d
😎 Deploy Preview https://deploy-preview-3753--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@jessieyan jessieyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look and see if we need to show maximumDataPoints in the json editor.

image

@erzhan-temir-mamyrov
Copy link
Collaborator Author

@jessieyan I've checked the content of JSON configuration and it depends on cardConfig prop. For example, I tried to add maximumDataPoints to card config prop in this story, then its field in displayed in JSON editor.

Copy link
Collaborator

@jessieyan jessieyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jessieyan jessieyan requested a review from herleraja April 17, 2023 20:40
@jessieyan
Copy link
Collaborator

@herleraja Hello Amritha, would you please also have a review?

Copy link
Collaborator

@herleraja herleraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BarChartCardFormSettings][TableCardFormSettings] add maximumDataPoints input
3 participants