Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetimepickerv2): add onClear callback #3761

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix(datetimepickerv2): add onClear callback #3761

merged 2 commits into from
Apr 19, 2023

Conversation

jessieyan
Copy link
Collaborator

@jessieyan jessieyan commented Mar 28, 2023

Closes #3760

Summary

  • Before we don't have onClear call back for user to reset date and time values.

Change List (commits, features, bugs, etc)

  • added onClear() callback prop for single select

Acceptance Test (how to verify the PR)

  • Go to single select story
  • Click on calendar button
  • Click on clear button
  • In action tab, see onClear was being called with empty objects

Regression Test (how to make sure this PR doesn't break old functionality)

Screen.Recording.2023-03-29.at.8.57.02.AM.mov

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@jessieyan jessieyan requested a review from davidicus as a code owner March 28, 2023 21:09
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 651db09
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/643db2a3c37e0f0008a09e06
😎 Deploy Preview https://deploy-preview-3761--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@erzhan-temir-mamyrov
Copy link
Collaborator

LGTM 👍

@kodiakhq kodiakhq bot merged commit 5364d65 into next Apr 19, 2023
@kodiakhq kodiakhq bot deleted the fix-3760 branch April 19, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DateTimePickerV2] expose onClear callback for single select
3 participants