Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetimepickerv2): make sure locale is 2 letters #3774

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix(datetimepickerv2): make sure locale is 2 letters #3774

merged 1 commit into from
Apr 25, 2023

Conversation

jessieyan
Copy link
Collaborator

Closes #3757

Summary

  • We need to make sure locale is 2 letters. If use passes in locale like "en-us", we make sure we use en instead of en-us

Change List (commits, features, bugs, etc)

  • Add locale checks for DateTimePicker and DateTimePickerv2

Acceptance Test (how to verify the PR)

  • go to single select story
  • change locale to 'en-us'
  • make sure no errors show up in the console

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 6e83d28
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6446ef0c119c410008b93e52
😎 Deploy Preview https://deploy-preview-3774--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@erzhan-temir-mamyrov erzhan-temir-mamyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sls-ca sls-ca merged commit 5de8caa into next Apr 25, 2023
@sls-ca sls-ca deleted the fix-3757 branch April 25, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DateTimePicker] Ensure that we are passing in a two letter locale
3 participants