Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appswitcher): firefox focus #3813

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

erzhan-temir-mamyrov
Copy link
Collaborator

@erzhan-temir-mamyrov erzhan-temir-mamyrov commented Jul 10, 2023

GRAPHITE-63825

Summary

  • Firefox only: disable focus on header panel menu when panel is closed

Change List (commits, features, bugs, etc)

  • Add dynamic tabIndex for header panel menu when panel is closed
  • Update snapshots

Acceptance Test (how to verify the PR)

  • In Firefox
  • Go to this story
  • Enable Mac Voice Over or JAWS
  • Put focus on App Switcher button
  • Press tab one more time
  • Verify that Screen Reader announces leaving the page and don't read panel menu items

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit bb0689b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/64abbe72b4e31700087ad913
😎 Deploy Preview https://deploy-preview-3813--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abpaul1993 abpaul1993 merged commit d799de7 into next Jul 10, 2023
@abpaul1993 abpaul1993 deleted the fix-firefox-appswitcher-focus branch July 10, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants