Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select the inner modal body css #3878

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: select the inner modal body css #3878

merged 1 commit into from
Aug 16, 2024

Conversation

herleraja
Copy link
Collaborator

@herleraja herleraja commented Aug 16, 2024

Closes https://jsw.ibm.com/browse/MASMON-1219

Summary

  • select the inner modal body CSS after carbon 10 upgrade. Earlier modal-content was direct child of modal-container now we have one more level.
    modal-container --> modal-container-body --> modal-content

Change List (commits, features, bugs, etc)

  • fix: select the inner modal body css

Acceptance Test (how to verify the PR)

Regression Test (how to make sure this PR doesn't break old functionality)

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 4607d6e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/66bf10285d884d0008e2f1dd
😎 Deploy Preview https://deploy-preview-3878--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sls-ca sls-ca merged commit fe6103e into next Aug 16, 2024
24 checks passed
@sls-ca sls-ca deleted the fix-imagecard-edit branch August 16, 2024 10:53
herleraja added a commit that referenced this pull request Nov 7, 2024
fixes: https://jsw.ibm.com/browse/MASMON-1219

Co-authored-by: Amritha raj herle <Amritha.Herle@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants