Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: locale format for cards #3903

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

simson1
Copy link
Contributor

@simson1 simson1 commented Dec 9, 2024

Closes #

Summary

  • Fix locale format

Change List (commits, features, bugs, etc)

  • For all cards default date and tooltip format changed to 'L HH:mm:ss'.
  • <DatePicker of the carbon library need locale in 2 digits for that we don't need to set locale of 2 digit in carbon-addons code.
  • Ex. For locale 'en-gb' and 'en' date format is diffrent. so we should not set locale in 2 digits.

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

Copy link
Collaborator

@herleraja herleraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herleraja herleraja merged commit cddbe4b into carbon-design-system:2.x.x Dec 9, 2024
6 of 8 checks passed
simson1 added a commit to simson1/carbon-addons-iot-react that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants