fix(ci): reconfigure coveralls to not swallow error exit codes #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tay1orjones
requested review from
blechner,
bryancboyd,
cgirani,
davidicus,
filipecorrea,
jessieyan,
leetosc,
scottdickerson,
sstone2423,
stuckless and
tomklapiscak
as code owners
|
Deploy preview for carbon-addons-iot-react ready! Built with commit c2a280b https://deploy-preview-920--carbon-addons-iot-react.netlify.com |
|
Some related discussion from others with the same problem on the coveralls tracker |
|
Deploy preview for carbon-addons-iot-react ready! Built with commit fb2003e https://deploy-preview-920--carbon-addons-iot-react.netlify.com |
|
Just pushed an updated snapshot file, #914 updated with latest master before merging which needed snapshots regenerated. Failing snapshots slipped through to |
sstone2423
approved these changes
Feb 18, 2020
JoelArmendariz
approved these changes
Feb 18, 2020
|
🎉 This PR is included in version 2.42.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #904 , #898
Summary
jestdirectly toyarn run coveralls. Due to this, error codes fromjestwere being swallowed and not causing build failures when coverage thresholds were not met.Change List (commits, features, bugs, etc)