fix(react): handle data updates from state, and fix errors with width…

…/height prop
carbon-design-system · Jun 25, 2019 · a00294f · a00294f
1 parent 01b30bf
commit a00294f
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/packages/react/src/base-chart.js b/packages/react/src/base-chart.js
@@ -10,17 +10,23 @@ export default class BaseChart extends React.Component {
 		// Width prop is mandatory for the wrappers
 		if (props.width) {
 			this.options.width = props.width;
-		} else {
+		} else if (!this.options.width) {
 			console.error("Missing `width` prop!");
 		}
 
 		// Height prop is mandatory for the wrappers
 		if (props.height) {
 			this.options.height = props.height;
-		} else {
+		} else if (!this.options.height) {
 			console.error("Missing `height` prop!");
 		}
 
 		Object.assign(this, this.chart);
 	}
+
+	componentDidUpdate(newProps) {
+		const { data } = newProps;
+
+		this.chart.setData(data);
+	}
 }