-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text in center of donut chart should update to relfect total #83
Comments
This was a design decision by our team, since the center of the donut is not anticipated to always show a sum of values. @dianatran18 or Nicole feel free to expand on that. However, sum and other possible values could be configured as modes that will be configured by the developer when initializing the chart. |
The original intention for the value in the center is to display the sum of the slices. |
I see, thanks @dianatran18. My mistake then |
The reason for not doing this automatically was to allow users to provide custom values and formatting which can be not related to sum of slices. How do they do that now? |
So the design requirement is that the value shows the sum. Now you can also
still manually update values, although the sum also gets calculated
automatically, so we would need an additional feature in the future to stop
the calculation of sum if user is setting values manually.
TLDR; we still support both, although an optimization is needed to stop
calculating sum if manually updating center text.
…On Tue, Nov 20, 2018 at 9:28 AM Zvonimir Fras ***@***.***> wrote:
The reason for not doing this automatically was to allow users to provide
custom values and formatting which can be not related to sum of slices. How
do they do that now?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOS57IGp_WZHYwzqoJ73O-5q9YSG4aEOks5uxBF2gaJpZM4YV1w0>
.
|
Currently the center of the donut chart displays a random value specified in the configs. After updating, another random value is generated. We should display the something more meaningful, such as the sum of the slices, and can update this value when a slice is selected/deselected from the legend.
The text was updated successfully, but these errors were encountered: