Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in center of donut chart should update to relfect total #83

Closed
JohnPeng47 opened this issue Nov 9, 2018 · 5 comments
Closed

Text in center of donut chart should update to relfect total #83

JohnPeng47 opened this issue Nov 9, 2018 · 5 comments

Comments

@JohnPeng47
Copy link
Contributor

Currently the center of the donut chart displays a random value specified in the configs. After updating, another random value is generated. We should display the something more meaningful, such as the sum of the slices, and can update this value when a slice is selected/deselected from the legend.

@theiliad
Copy link
Member

theiliad commented Nov 9, 2018

This was a design decision by our team, since the center of the donut is not anticipated to always show a sum of values.

@dianatran18 or Nicole feel free to expand on that.

However, sum and other possible values could be configured as modes that will be configured by the developer when initializing the chart.

@dianasanborn
Copy link

The original intention for the value in the center is to display the sum of the slices.

@theiliad
Copy link
Member

theiliad commented Nov 9, 2018

I see, thanks @dianatran18. My mistake then

@zvonimirfras
Copy link
Member

The reason for not doing this automatically was to allow users to provide custom values and formatting which can be not related to sum of slices. How do they do that now?

@theiliad
Copy link
Member

theiliad commented Nov 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants