refactor(axis): use css-classes instead of style #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the DCO. |
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
max-jonas
force-pushed
the
1896-ticks-with-classes
branch
from
af35ca7
to
4bc8a04
Compare
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
theiliad
requested changes
Sep 27, 2024
| @@ -32,6 +32,14 @@ | |||
| g.tick text { | |||
| fill: theme.$text-secondary; | |||
| font-family: var(--#{globals.$prefix}-charts-font-family-condensed); | |||
|
|
|||
| &.primary-tick-label { | |||
There was a problem hiding this comment.
Suggested change
| &.primary-tick-label { | |
| &.tick-label--primary { |
| }) | ||
| ticks.attr('class', (tick: number, i: number) => | ||
| isTickPrimary(tick, i, axis.tickValues(), timeInterval, showDayName) | ||
| ? 'primary-tick-label' |
There was a problem hiding this comment.
Suggested change
| ? 'primary-tick-label' | |
| ? 'tick-label--primary' |
* adds css-classes to ticks to make them more accessible from outside Signed-off-by: Max Jonas <maximilian.jonas@dedalus.com>
max-jonas
force-pushed
the
1896-ticks-with-classes
branch
from
c1d8130
to
99e7ea0
Compare
theiliad
approved these changes
Nov 7, 2024
nstuyvesant
added a commit
to nstuyvesant/carbon-charts
that referenced
this pull request
Nov 7, 2024
fix(docs): switch fonts to s81c cdn (carbon-design-system#1898) chore(release): publish 1.22.1 chore(deps): bump (carbon-design-system#1906) chore(deps): bump test(svelte): replace deprecated svelte:component chore(deps): bump chore(deps): bump chore(deps): bump chore(deps): bump chore(deps): bump chore(deps): bump chore(deps): bump chore(svelte): peers chore(deps): lock chore(telemetry): update endpoint for main (carbon-design-system#1905) * chore(telemetry): update endpoint * fix(telemetry): update angular README refactor(axis): use css-classes instead of style (carbon-design-system#1897) * refactor(axis): use css-classes instead of style * adds css-classes to ticks to make them more accessible from outside Signed-off-by: Max Jonas <maximilian.jonas@dedalus.com> * refactor(axis): rename css class --------- Signed-off-by: Max Jonas <maximilian.jonas@dedalus.com> skip-release fix(yarn): make local to CI fix(yarn): bundle because CI lacks corepack (carbon-design-system#1911) chore(release): publish 1.22.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates