chore(monorepo): Update README content #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for kind-hypatia-c6b5c4 ready! Built with commit a4fe28c |
|
Deploy preview for kind-hypatia-c6b5c4 ready! Built with commit 6dbd99b |
zvonimirfras
suggested changes
Nov 6, 2018
| @@ -73,8 +73,8 @@ npm run storybook | |||
| Demos all features | All interactions spec'd out in the Design Guide has visual support and a demo as proof. | |||
| Documented/annotated | All rule blocks, placeholders, mixins, and functions has associated comment blocks that convey purpose and list inline notations referencing declarations that need further explanation. | |||
| Matches UI/UX specs | All features are pixel perfect when compared to the Design Guide. | |||
| Meets the [code style guide](https://github.com/IBM/carbon-charts/wiki/Code-style-guide) | All code adheres to our custom style guide giving off the impression that it was written by one developer. | |||
| Accessible | All code passes the [Dynamic Assessment Plugin (DAP)](https://w3-connections.ibm.com/wikis/home?lang=en-us#!/wiki/W88ee03f8907c_412b_a3a8_988dabb72b35/page/Dynamic%20Assessment%20Plugin) scan in Chrome. | |||
| All new code follows similar structure and style to the existing codebase giving off the impression that it was written by one developer. | |||
There was a problem hiding this comment.
Although give off could be an accurate representation of what following a similar structure and style accomplishes, it could also be easily misunderstood ;)
|
Deploy preview for kind-hypatia-c6b5c4 ready! Built with commit 32405b9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates