feat: add contained-list #2464
Merged
feat: add contained-list #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-angular-next ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
maicongodinho
force-pushed
the
contained-list
branch
2 times, most recently
from
680d354 to
5f35fa4
Compare
Akshat55
requested changes
Feb 27, 2023
maicongodinho
force-pushed
the
contained-list
branch
4 times, most recently
from
7f99ac9 to
2c259b1
Compare
Akshat55
requested changes
Mar 7, 2023
maicongodinho
force-pushed
the
contained-list
branch
3 times, most recently
from
102a0f8 to
2babc48
Compare
Akshat55
requested changes
Mar 24, 2023
maicongodinho
force-pushed
the
contained-list
branch
3 times, most recently
from
43b7f43 to
d33a301
Compare
Akshat55
previously approved these changes
Apr 10, 2023
|
Just an FYI @maicongodinho We are looking to merge this into master soon - Once |
maicongodinho
force-pushed
the
contained-list
branch
from
8c44387 to
08d62da
Compare
|
As per @Akshat55's request, I have made the following updates:
|
Signed-off-by: Maicon Godinho <maicongodinho1@gmail.com>
Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>
Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>
maicongodinho
force-pushed
the
contained-list
branch
from
e6c2a01 to
97b86aa
Compare
Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>
|
Thank you for the heads up. I think everything is good now if you want to check. |
Akshat55
previously approved these changes
Aug 29, 2023
zvonimirfras
requested changes
Sep 8, 2023
Co-authored-by: Zvonimir Fras <zvonimir.fras@gmail.com>
Co-authored-by: Zvonimir Fras <zvonimir.fras@gmail.com>
Signed-off-by: Akshat Patel <akshat@live.ca>
Akshat55
approved these changes
Oct 18, 2023
zvonimirfras
approved these changes
Oct 20, 2023
|
🎉 This PR is included in version 5.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contained List component 🥳
Reference: https://carbondesignsystem.com/components/contained-list/usage/
React team implementation: https://react.carbondesignsystem.com/?path=/story/components-containedlist--default