-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add password input #2772
feat: add password input #2772
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
In the context of React components, where a "directive-like" solution is not employed, my approach to the new component involves maintaining the use of projection. A type flag is utilized to seamlessly switch between templates representing different input types, thus ensuring native HTML5 password handling. To implement this, users are required to utilize two inputs accompanied by the Building upon the React component reference found at https://react.carbondesignsystem.com/?path=/story/components-textinput--toggle-password-visibility Hope that covers all 😄 |
Sorry to butt in, but is there any update on this PR? |
Sorry, been preoccupied, let me prioritize this for this week and we can hopefully merge it sometimes next week. @maicongodinho, I'm going to make a few simplifications to this. I want to be able to toggle input property type so users don't have to project both |
Hey @Akshat55, indeed, this is an older implementation. I aimed to leverage the directive style, integrating best practices in security and accessibility from the React library. While exploring simplification within our existing structure, I couldn't find an optimal solution. However, we could consider developing a new, consolidated component that combines the functionality of labels and password features seamlessly. Let me know what you think and what you need from my side. |
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Hi @Akshat55, I just saw the approach you took. Excellent use of setting the property to the native element. I hadn't considered this method myself. Really good work! |
🎉 This PR is included in version 5.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #1930
This update introduces a new password input component, encompassing all essential features available in the base text input component.