Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable textarea counter #3058

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Akshat55
Copy link
Contributor

Changelog

New

  • Enable text area counter

Signed-off-by: Akshat Patel <akshat@live.ca>
@Akshat55 Akshat55 requested a review from a team as a code owner November 14, 2024 05:07
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit dac4d2d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/6760da8af9365b0008a6a8bd
😎 Deploy Preview https://deploy-preview-3058--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brampeirs
Copy link
Contributor

Q: is this still WIP?
When testing in storybook, the fluid layout seems broken
Scherm­afbeelding 2024-11-14 om 10 15 23
The counter does also not update when typing.

@Akshat55
Copy link
Contributor Author

Akshat55 commented Nov 14, 2024

Q: is this still WIP? When testing in storybook, the fluid layout seems broken

@brampeirs Not WIP, it's ready for review. I verified this in other implementations, seems like counter isn't compatible with fluid states as of now - fluid states are still experimental. It should be fixed in future @carbon/styles releases.

@eduardmarcinco
Copy link
Contributor

@Akshat55 Counter isnt updating for me.
I've set maxlength to 100 and enabled enableCounter.
When I toggle enableCounter, the counter is updated but it isnt updating as I type.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants