fix(overflow-menu): update semantic attributes in OverflowMenuItem

carbon-design-system · Jul 14, 2021 · af1caf9 · af1caf9
1 parent ac4dff0
commit af1caf9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/OverflowMenu/OverflowMenuItem.svelte b/src/OverflowMenu/OverflowMenuItem.svelte
@@ -43,16 +43,17 @@
 
   $: primaryFocus = $focusedId === id;
   $: buttonProps = {
+    role: "menuitem",
     tabindex: "-1",
-    title: requireTitle ? text : undefined,
     class: "bx--overflow-menu-options__btn",
     disabled: href ? undefined : disabled,
     href: href ? href : undefined,
+    title: requireTitle ? text : undefined,
   };
 </script>
 
 <li
-  role="menuitem"
+  role="none"
   id="{id}"
   class:bx--overflow-menu-options__option="{true}"
   class:bx--overflow-menu--divider="{hasDivider}"